feat: DAH-3399 use unit status rather than iterating over leases #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alulabeshue-sfgov
changed the title
alulabeshue-sfgov
requested review from
a team,
cade-exygy and
jimlin-sfgov
and removed request for
a team
jimlin-sfgov
approved these changes
May 12, 2025
| @@ -53,7 +53,7 @@ http_interactions: | |||
| recorded_at: Mon, 11 Mar 2024 21:47:14 GMT | |||
| - request: | |||
| method: get | |||
| uri: https://<<SALESFORCE_HOST>>/services/data/v<<SALESFORCE_API_VERSION>>/query?q=SELECT%20Id,%20Priority_Type__c,%20AMI_chart_type__c,%20Max_AMI_for_Qualifying_Unit__c,%20Unit_Number__c,%20Unit_Type__c,%20AMI_chart_year__c,%20(SELECT%20Application__c,%20Lease_Status__c,%20Preference_Used_Name__c%20FROM%20Leases__r)%20FROM%20Unit__c%20WHERE%20(Listing__c%20=%20%27a0W0P00000GbyuQUAR%27) | |||
| uri: https://<<SALESFORCE_HOST>>/services/data/v<<SALESFORCE_API_VERSION>>/query?q=SELECT%20Id,%20Priority_Type__c,%20AMI_chart_type__c,%20Max_AMI_for_Qualifying_Unit__c,%20Unit_Number__c,%20Unit_Type__c,%20AMI_chart_year__c,%20Status__c,%20(SELECT%20Application__c,%20Lease_Status__c,%20Preference_Used_Name__c%20FROM%20Leases__r)%20FROM%20Unit__c%20WHERE%20(Listing__c%20=%20%27a0W0P00000GbyuQUAR%27) | |||
There was a problem hiding this comment.
question: Despite Status__c being in the request, I don't see it in the response body. Did you recreate this VCR cassette by deleting it and then re-running tests?
There was a problem hiding this comment.
Good catch, I've recreated the cassettes from scratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DAH-3399
Description
In the Lease panel of an application only show available units based on unit status rather than leases attached to a unit. Rely on salesforce automation to properly set the status of a unit rather than having to iterate over the leases to determine the unit status.
Review Instructions
Use review instructions on jira ticket